View unanswered posts | View active topics
Author |
Message |
gileadslostson
|
Posted: Tue Jun 26, 2012 6:36 am |
|
Joined: Sun Jun 01, 2008 11:03 am Posts: 580 Location: Vienna, Austria
|
I'm working on getting the forum back to its former glory so I need a wee bit of help If you notice any bugs or errors please let me know in this thread, I'm fairly new to php so it is entirely likely that I have missed something. [edit] I know that the logo is missing and a few icons Cheers in advance!
|
|
Top |
|
 |
Andy
|
Posted: Tue Jun 26, 2012 8:31 am |
|
Joined: Fri Feb 23, 2007 3:14 pm Posts: 1467 Location: Interzone
|
You've done a great job Marc, well done. I've spotted a couple of things, not bugs exactly, just old code. The Fix link needs to be deleted. It now takes us to a life coach website... And the 'text size' icons (the As in the top right corner) don't affect this page unsurprisingly but take us away from the forum to view the website accessibility. Very minor things. Fact that you got the... what's it called again, that top bit?... back again is fantastic, and I know what a chore that must've been.
|
|
Top |
|
 |
Andy
|
Posted: Tue Jun 26, 2012 8:33 am |
|
Joined: Fri Feb 23, 2007 3:14 pm Posts: 1467 Location: Interzone
|
On Safari (don't know about other browsers) the forum never quite fits in the window, no matter how big I make the window. Does anybody else see that?
|
|
Top |
|
 |
gileadslostson
|
Posted: Tue Jun 26, 2012 8:46 am |
|
Joined: Sun Jun 01, 2008 11:03 am Posts: 580 Location: Vienna, Austria
|
Thanks Andy, I'll hopefully have them sorted this evening or tomorrow. I probably just have to change a function or two. And the Navbar (that bit up top  ) was murder lol
|
|
Top |
|
 |
gileadslostson
|
Posted: Tue Jun 26, 2012 10:49 am |
|
Joined: Sun Jun 01, 2008 11:03 am Posts: 580 Location: Vienna, Austria
|
The sizing issue seems to be across the board, well chrome & firefox at any rate. Anyone know if it's the same on IE or Opera?
Text size should be easy to sort from what I've seen. I'll do it once I am home.
|
|
Top |
|
 |
Pete
|
Posted: Tue Jun 26, 2012 11:06 am |
|
Joined: Mon Feb 26, 2007 2:15 pm Posts: 3341
|
Forum fits okay on Firefox and IE for me.
|
|
Top |
|
 |
gileadslostson
|
Posted: Tue Jun 26, 2012 11:44 am |
|
Joined: Sun Jun 01, 2008 11:03 am Posts: 580 Location: Vienna, Austria
|
Thanks Pete, it must be something small that I have missed then.
|
|
Top |
|
 |
Mike A
|
Posted: Tue Jun 26, 2012 12:07 pm |
|
Joined: Mon Apr 23, 2007 9:25 am Posts: 619 Location: Sussex Coast
|
Marc, looks most likely to be a problem with margins/padding somewhere in that top banner. I see a couple of elements have a 20px pad on the left. Perhaps an inherited width of 100% but with added margins/padding throwing it out beyond the browser window size? Can't quite pin it down at the moment though.
cheers, Mike
|
|
Top |
|
 |
Mike A
|
Posted: Tue Jun 26, 2012 12:14 pm |
|
Joined: Mon Apr 23, 2007 9:25 am Posts: 619 Location: Sussex Coast
|
Just a suggestion Marc: try assigning margin-right: -20px to #primary_nav h1
cheers, Mike
|
|
Top |
|
 |
gileadslostson
|
Posted: Tue Jun 26, 2012 12:16 pm |
|
Joined: Sun Jun 01, 2008 11:03 am Posts: 580 Location: Vienna, Austria
|
Mike, you win one half of my promised Ferrari  seems to have been a case of 'forest for the trees'. Should be easy to fix. Thank you!
|
|
Top |
|
 |
Mike A
|
Posted: Tue Jun 26, 2012 12:33 pm |
|
Joined: Mon Apr 23, 2007 9:25 am Posts: 619 Location: Sussex Coast
|
Actually, no, that doesn't work at all! The problem is being caused by this code for #primary_nav: Code: /*To compensate for right page margin hack.*/ margin: 0px -20px 0px 0px; I can't see why that negative margin hack is there, but setting the body element with Code: padding-right: 20px; corrects the problem, though it also seems to knock the main table off-centre. Just removing the negative margin and leaving all margins for #primary_nav set to 0 seems to get a good result, at least for me. Anyway, hope that gives some useful pointers. CSS can be a nightmare! cheers, Mike.
|
|
Top |
|
 |
gileadslostson
|
Posted: Tue Jun 26, 2012 12:35 pm |
|
Joined: Sun Jun 01, 2008 11:03 am Posts: 580 Location: Vienna, Austria
|
Mike A wrote: Just a suggestion Marc: try assigning margin-right: -20px to #primary_nav h1
cheers, Mike Seems sorted to me. I had it already on -20px so I've set it to 0px. Fixed for everyone or just me? Thanks again Mike 
|
|
Top |
|
 |
Mike A
|
Posted: Tue Jun 26, 2012 12:40 pm |
|
Joined: Mon Apr 23, 2007 9:25 am Posts: 619 Location: Sussex Coast
|
No worries Marc. Re: the Ferrari, I'll settle for just the tyres if you like, as they're probably worth more than my Toyota Yaris. 
|
|
Top |
|
 |
Andy
|
Posted: Tue Jun 26, 2012 1:47 pm |
|
Joined: Fri Feb 23, 2007 3:14 pm Posts: 1467 Location: Interzone
|
Fixed for me on safari. Well done Marc, and thanks Mike. 
|
|
Top |
|
 |
Ray
|
Posted: Tue Jun 26, 2012 3:47 pm |
|
Joined: Wed May 14, 2008 2:06 pm Posts: 1041 Location: Portsmouth
|
Good to see the shortcuts back at the top. 
|
|
Top |
|
 |
Who is online |
Users browsing this forum: No registered users and 2 guests |
|
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot post attachments in this forum
|
|